Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanup: make createSymlinkFile internal #6630

Merged
merged 1 commit into from
Sep 20, 2023
Merged

API cleanup: make createSymlinkFile internal #6630

merged 1 commit into from
Sep 20, 2023

Conversation

johnnyaug
Copy link
Contributor

Resolves #6538

@johnnyaug johnnyaug added the include-changelog PR description should be included in next release changelog label Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

♻️ PR Preview 254a88f has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@johnnyaug johnnyaug changed the title remove create symlink API cleanup: remove create symlink Sep 20, 2023
@johnnyaug johnnyaug marked this pull request as ready for review September 20, 2023 10:57
nopcoder
nopcoder suggested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecate the API by use internal tag first.

@johnnyaug johnnyaug closed this Sep 20, 2023
@johnnyaug johnnyaug force-pushed the 1.0/remove_create_symlink branch from e1e5101 to bc5bfaf Compare September 20, 2023 12:17
@johnnyaug johnnyaug reopened this Sep 20, 2023
@johnnyaug johnnyaug changed the title API cleanup: remove create symlink API cleanup: make createSymlinkFile internal Sep 20, 2023
@johnnyaug johnnyaug requested a review from nopcoder September 20, 2023 12:44
@nopcoder
Copy link
Contributor

Great - note that for the changelog we mark this API as internal

nopcoder
nopcoder approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnnyaug johnnyaug merged commit 7e1be21 into master Sep 20, 2023
@johnnyaug johnnyaug deleted the 1.0/remove_create_symlink branch September 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

@arielshaqed arielshaqed Awaiting requested review from arielshaqed

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API cleanup: createSymlinkFile
2 participants
@johnnyaug @nopcoder